Skip to content

Update some board csc file#9573

Open
retro98boy wants to merge 2 commits intoarmbian:mainfrom
retro98boy:update-some-board-csc
Open

Update some board csc file#9573
retro98boy wants to merge 2 commits intoarmbian:mainfrom
retro98boy:update-some-board-csc

Conversation

@retro98boy
Copy link
Contributor

@retro98boy retro98boy commented Mar 21, 2026

  • Update board vendor and comments in csc files

  • Add missing Xorg configuration for BesTV R3300-L (Amlogic S905L-B GXL)

Depends on this PR

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated board vendor metadata to reflect accurate vendor information for board configurations.
    • Improved audio subsystem initialization by implementing explicit hardware card targeting to ensure correct device identification during audio setup.
    • Extended board compatibility support in common board family configuration files to include additional board models.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4fdb829a-4c80-41bc-bc79-7d8e20399ef0

📥 Commits

Reviewing files that changed from the base of the PR and between b8eab09 and e656d5b.

📒 Files selected for processing (3)
  • config/boards/bestv-r3300-l.csc
  • config/boards/smart-am40.csc
  • config/sources/families/include/meson64_common.inc

📝 Walkthrough

Walkthrough

Three board configuration files are updated to reflect corrected vendor metadata: bestv-r3300-l transitions from amlogic to bestv vendor classification with refined ALSA hardware card targeting, smart-am40 transitions from rockchip to smart vendor, and the meson64 family configuration is extended to include bestv-r3300-l in X11 driver configuration logic.

Changes

Cohort / File(s) Summary
Board Vendor Metadata
config/boards/bestv-r3300-l.csc, config/boards/smart-am40.csc
Updated BOARD_VENDOR values: bestv-r3300-l from "amlogic" to "bestv" and smart-am40 from "rockchip" to "smart". ALSA UCM CLI instructions for bestv-r3300-l now explicitly target hardware card hw:S905XP212.
Family Board Configuration
config/sources/families/include/meson64_common.inc
Extended family_tweaks_bsp() board selection pattern to include bestv-r3300-l for X11 driver configuration (02-driver.conf).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Boards find their homes, new names so bright,
From amlogic, rockchip takes a flight,
Bestv and Smart now claim their place,
With configs tweaked at matching grace,
The rabbit hops—all vendors aligned!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update some board csc file' is vague and uses generic phrasing ('some') that doesn't convey meaningful information about the specific changes made. Consider a more descriptive title like 'Update board vendor metadata and add Xorg configuration for BesTV R3300-L' to clearly communicate the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 05 Milestone: Second quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... size/small PR with less then 50 lines labels Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant